Add TaggedMap to permitted_classes to accomodate Psych with Ruby >= 3.1 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonggrijp
added
the
infrastructure
|
Given the lack of response, I'm just going to merge this and hope for the best. Comments after the fact welcome, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #176, I wanted to regenerate the JSON files to double-check the updates in there. This initially failed, because I upgraded to Ruby 3.2 in the meanwhile and the Psych dependency is much stricter now.
By way of review, I would appreciate a confirmation that someone with Ruby < 3.1 is also still able to generate the JSON after these changes.