Feature/tidal-quality-updates #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arctixdev
reviewed
Sep 1, 2023
|
What's the breaking change here ? |
New config property, that does not exist prior to this version |
|
But you have a default value right ? So then it should not break ?! |
|
True. I can test it in a little while but I just reinstalled my MacBook and I'm at my in laws house at the moment |
|
Going from previous setup provider on main branch and then switching to this feature branch, there was indeed no error. Everything plays nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tidal api
Enable HI RES
Add Quality selector to config map
Re-add track limit for similar tracks function
Add parsing to determine stream quality