Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base url settable by providing MASS_BASE_URL #592

Closed
wants to merge 1 commit into from

Conversation

bennnnnnnn
Copy link

Hi Marcel,

Tiny change to be able to use MASS_BASE_URL to set the Music assistant base url, similar to MA1.

Kind regards,
Ben

@marcelveldt
Copy link
Member

Sorry, that is not going to work this time. devices must be able to reach the MA server on IP address, no https, no dns name. The default 8095 port is also used for all kind of callbacks.

What is your usecase ? Reaching the web server ? Because I'm going to provide an option to start a second interface of the webserver for other purposes but first I need to finish the HA auth on the websocket.

@marcelveldt
Copy link
Member

Can't you use a reverse proxy btw ? Or maybe I should include a base config in the container ?

@bennnnnnnn
Copy link
Author

My use case is that I'm running a k3s cluster. Ideally I'd like to expose the webserver frontend through traefik (with ssl offloading) and expose the streaming webserver directly through a service IP, I'd like to specify that service IP as the base url for the streaming clients.

@marcelveldt
Copy link
Member

As discussed on discord we're going to implement it a bit more flexible. I'll pick it up in between somewhere next days.

https://github.com/orgs/music-assistant/projects/2/views/1?pane=issue&itemId=24191084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants