Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YoutubeMusic MusicProvider #397

Merged
merged 46 commits into from
Jul 7, 2022
Merged

Add YoutubeMusic MusicProvider #397

merged 46 commits into from
Jul 7, 2022

Conversation

MarvinSchenkel
Copy link
Contributor

@MarvinSchenkel MarvinSchenkel commented Jul 6, 2022 •
edited
Loading

This PR adds a first version of support for Youtube Music. It features:

  • Library sync of artists, albums, playlists and tracks
  • Details around artists, albums, playlists and tracks
  • Search functionality

A few things to note:

  • This Provider is based on an unofficial API for Youtube Music (since there is no official one)
  • Parsing this beast of what Google calls an API has been quite tedious, so let's pray I found all the edge cases :-)
  • There is (as far as I am aware) no way for a proper OAuth login sequence. This means that, in order to login, users will have to figure out the value of their cookie using a PC browser. Details on how to achieve this can be found here

Marvin Schenkel and others added 25 commits June 30, 2022 21:53
@MarvinSchenkel
Update settings
c5879a9
@MarvinSchenkel
Can query albums and tracks
2b1ff23
@MarvinSchenkel
Add url parsing for playback
9956711
@MarvinSchenkel
Generate valid stream urls
5da0716
@MarvinSchenkel
Parse artist, album and track
0924725
@MarvinSchenkel
Add serach for artist and album
d90a093
@MarvinSchenkel
Add get_album_tracks and get_playlist_tracks
5efd176
@MarvinSchenkel
precommit fixes
81c4a32
@MarvinSchenkel
Add library_artist and library_album
61bafe9
@MarvinSchenkel
Add authentication from config
2c0ccc1
@MarvinSchenkel
Add library playlist, library songs and artist albums
c2cd62f
@MarvinSchenkel
Update settings
c82e1b4
@MarvinSchenkel
Can query albums and tracks
4c0eb68
@MarvinSchenkel
Add url parsing for playback
67d1b2c
@MarvinSchenkel
Generate valid stream urls
e0712ce
@MarvinSchenkel
Parse artist, album and track
297811d
@MarvinSchenkel
Add serach for artist and album
8e4eeaf
@MarvinSchenkel
Add get_album_tracks and get_playlist_tracks
b6a3448
@MarvinSchenkel
precommit fixes
7b2b8c2
@MarvinSchenkel
Add library_artist and library_album
99573b7
@MarvinSchenkel
Add authentication from config
e9e279d
@MarvinSchenkel
Add library playlist, library songs and artist albums
84fba16
@MarvinSchenkel
Add library playlist, library songs and artist albums
31f0a95
@MarvinSchenkel
Add library playlist, library songs and artist albums
ac4814a
@MarvinSchenkel
Merge branch 'music-assistant:master' into master
8152e95
@MarvinSchenkel MarvinSchenkel marked this pull request as draft July 6, 2022 14:32
marcelveldt and others added 19 commits July 6, 2022 16:42
@marcelveldt
Update artists.py
09d0cf9
@marcelveldt
adjust example
ec0ad07
@marcelveldt
Update full.py
01c1210
@MarvinSchenkel
Add artist to track when possible
5d01114
@MarvinSchenkel
Merge branch 'master' of https://github.com/MarvinSchenkel/music-assi…
9a04b98 
…stant-lib
@marcelveldt
fix streaming
c4a732e 
audio format is m4a
@marcelveldt
Merge branch 'master' of https://github.com/MarvinSchenkel/music-assi…
1dda6a5 
…stant-lib into pr/397
@marcelveldt
parse contenttype
9731666
@MarvinSchenkel
Fix parse tracks
43ab57c
@MarvinSchenkel
Merge branch 'master' of https://github.com/MarvinSchenkel/music-assi…
cd3b14d 
…stant-lib
@marcelveldt
guard missing album
aafe581
@marcelveldt
lint
5b5cf9c
@marcelveldt
Merge branch 'master' into pr/397
ade2488
@MarvinSchenkel
Various prasing fixes
fe72c05
@marcelveldt
run blocking call in executor
d3c41ec
@MarvinSchenkel
Fix track images
735938e
@MarvinSchenkel
Merge branch 'master' of https://github.com/MarvinSchenkel/music-assi…
b77af98 
…stant-lib
@MarvinSchenkel
Add artist top tracks
6a9e782
@MarvinSchenkel
Remove ytmusic example
a6e6cb7
@MarvinSchenkel MarvinSchenkel marked this pull request as ready for review July 7, 2022 14:41
@marcelveldt marcelveldt merged commit a211eae into music-assistant:master Jul 7, 2022
@marcelveldt
Copy link
Member

Amazing job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelveldt marcelveldt marcelveldt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinSchenkel @marcelveldt