fix: Make sure that Jellyfin playlists are sorted and paginated #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fetching is paginated
1 task
|
Not certain but this may help with music-assistant/support#3278 as it is using the correct interface for fetching playlist tracks. Whilst the old way "worked" (albeit unsorted) its possible its a fluke of the specific data in my Jellyfin instance. Using a playlist specific endpoint may account for whatever data difference this is. |
marcelveldt
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the wrong endpoint for playlists so they were unsorted. We also need to use the order that they are returned in, rather than any index from the track object itself.
This also fixes pagination for that API endpoint.