Throttler: sleep without busy wait, log delayed calls #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI found an issue in the code, can you check that please ? Tip: to setup the dev environment use the scripts\setup.sh |
chatziko
force-pushed
the
improve-throttling
branch
from
a1db478 to
65d8066
Compare
chatziko
force-pushed
the
improve-throttling
branch
from
65d8066 to
782e017
Compare
|
That's strange, the pre-commit checks are passing in my vscode dev container. Even stranger is that the failing line was not changed by me but by the ruff formatter! But now I ran the formatter again and it didn't make the same change. Weird... Anyway I recommitted without the formatting changes and it seems to pass now. |
|
Maybe a version mismatch of the ruff formatter in your dev container and CI ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two improvements to throttling:
Accurate sleep until the next available time.
asyncio_throttleby default wakes every 10msecs which is crazy.ThrottlerManagersets the wait to 100mecs, which is still unnecessary, but some modules don't useThrottlerManageranyway.Return the delay caused by the throttler (0 means no throttling) and log it in
throttle_with_retries.Since
asyncio_throttleis very simple and looks unmaintained (PR ignored for years) I copied the code inserver/helpers/throttle_retry.py, no point having an unmaintained dependency for a few lines of code.