Remove deprecated constants #2974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I might be way off target here but warnings in HA 2024.10 beta and the associated release notes point to here https://developers.home-assistant.io/blog/2024/09/23/constants-media-player-deprecation/ Looking at the HA code I have come up with this PR. I won't be upset if this is totally wrong! :-)
|
OK I pasted this into my local instance and the integration started without errors so I think it is good but I don't know how to fix the ruff lint problem...? |
marcelveldt
reviewed
Oct 10, 2024
| @@ -28,14 +19,14 @@ | |||
| if TYPE_CHECKING: | |||
| from music_assistant.client import MusicAssistantClient | |||
|
|
|||
| MEDIA_TYPE_RADIO = "radio" | |||
| MediaType.RADIO = "radio" | |||
There was a problem hiding this comment.
this is not the way to add an another enum member, better keep the previous custom constant if radio doesnt exist in the HA MediaType enum
There was a problem hiding this comment.
I think I tried that but lint said no….something said no….
edit: just looked at my commit and yes it was a lint error?
|
deprecated by #3057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be way off target here but warnings in HA 2024.10 beta and the associated release notes point to here https://developers.home-assistant.io/blog/2024/09/23/constants-media-player-deprecation/
Looking at the HA code I have come up with this PR. I won't be upset if this is totally wrong! :-)