Fix #1781: compact_items expects dict but sometimes passed list

[jacobswe]

This pull request fixes #1781 by implementing a simple type check before invoking compact_items. I wasn't able to find any docs on preferences for contributing, so please shoot this back to me if any changes are needed!

Summary:
With Spotify connected, running the mass.search service causes an error to occur if track is passed as a media_type. This occurs because the compact_items function in mass/services.py expects and is type hinted to exclusively accept a dictionary, but when called from handle_search or recursively from within compact_items, no check is performed to ensure the correct type is passed. This usually does not cause errors, but in some circumstances lists are passed, in the case of the below example for the external_ids field.

Recreation YAML:

service: mass.search
data:
  limit: 5
  name: Pink Floyd
  media_type:
    - track

Error:
The error TypeError: pop expected at most 1 argument, got 2 is thrown because list.pop expects a single index whereas dict.pop expects a key and optionally a default value. This causes improper arguments to be passed when a list is given to compact_items.

Working Local Demonstration:

[jacobswe]

Hey HA music wizards, just wondering if I can do anything on this. Totally get you're probably busy but let me know! It would be cool to get this enabled on the public release.

[marcelveldt]

It's always better to guard and breakout early. So in this case:

if not isinstance(subitem, dict):
continue

[marcelveldt]

btw: maybe we also want to catch lists here ?

[jacobswe]

Thanks, happy to make that update, and I'll think about how to capture lists as well. I'll have time to push some changes on Sunday probably. Appreciate the review!

[jacobswe]

Pushed the guard clauses and verified working. I don't think anything is needed for lists here, they should just work I think? If required, can we do in separate merge?

[marcelveldt]

Thanks!