Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to be more like light intent #1743

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Refactor to be more like light intent #1743

merged 3 commits into from
Jan 2, 2024

Conversation

jozefKruszynski
Copy link
Contributor

Removed a bunch of custom stuff that was overcomplicated and refactored to be more like the official light component intent code

marcelveldt
marcelveldt approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - feel free to merge if your tests succeed

@jozefKruszynski jozefKruszynski merged commit 90ade73 into main Jan 2, 2024
6 checks passed
@jozefKruszynski jozefKruszynski deleted the refactor-intent-code branch January 2, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelveldt marcelveldt marcelveldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozefKruszynski @marcelveldt