fix: format media_position_updated_at attribute as ISO time
#1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's a timestamp in seconds which causes some issues when HAss tries to parse it because JavaScript assumes timestamps are in milliseconds. Formatting the time as ISO String (YYYY-MM-DDTHH:mm+HHMM) makes parsing errors much less likely. Closes music-assistant#1401
|
Nice catch and thanks for implementing the solution right away! |
|
Yep, been testing it locally and I haven't found any issues so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the attribute is a timestamp in seconds (because that's what python's
timeuses) which causes some issues when HAss tries to parse it because JavaScript assumes timestamps are in milliseconds. Formatting the time as ISO String (YYYY-mm-DDTHH:MM+HHMM) makes parsing errors much less likely.Closes #1401