-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a frameless param #745
feat: Add a frameless param #745
Conversation
maybe keep "player" param to select the default player (on any view) and introduce a new param like "openview" or something like that ? |
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
@marcelveldt I thought of that first. But I was not sure about adding a breaking change. If we are fine with that I'm happy to change |
I think its fine as we are still early on in the cycle and this feature is not very known. |
@marcelveldt sounds good, let know what you think of it. Happy to rename anything if you want it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
This will be a great update! Thanks @felipetoffolo1 |
wait - so https://myurl:xxxx/#/playlists?frameless=true&targetPlayer=MyBasementPlayer will give me the playlist window, without the media player and the menu bar? THIS-IS-HUGE. At this point, you have effectively made MA totally modular. s. |
I'm adding a param called frameless
So that different view of MASS can be used in cards (original suggestion)
Added 2 new params
player
param already. Put that param open the fullscreen player. And it might not be what we want.Moved code that handled
player
to the defaultView so that everything is in the same placemass-v-1.mov