Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a frameless param #745

Merged

Conversation

felipetoffolo1
Copy link
Contributor

@felipetoffolo1 felipetoffolo1 commented Nov 22, 2024

I'm adding a param called frameless

So that different view of MASS can be used in cards (original suggestion)

  • Added 2 new params

    • frameless: Load just the content without the footer and navigation. It won't be saved in the store so that it goes away everytime we reload
    • targetPlayer: using that to select the activePlayer. I know we have a player param already. Put that param open the fullscreen player. And it might not be what we want.
  • Moved code that handled player to the defaultView so that everything is in the same place

mass-v-1.mov

@marcelveldt
Copy link
Member

marcelveldt commented Nov 22, 2024

maybe keep "player" param to select the default player (on any view) and introduce a new param like "openview" or something like that ?

felipetoffolo1 and others added 2 commits November 22, 2024 14:58
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
@felipetoffolo1
Copy link
Contributor Author

felipetoffolo1 commented Nov 22, 2024

maybe keep "player" param to select the default player (on any view) and introduce a new param like "openview" or something like that ?

@marcelveldt I thought of that first. But I was not sure about adding a breaking change. If we are fine with that I'm happy to change

@marcelveldt
Copy link
Member

@marcelveldt I thought of that first. But I was not sure about adding a breaking change. If we are fine with that I'm happy to change

I think its fine as we are still early on in the cycle and this feature is not very known.
Let's just make it work great instead of half baken. We should just be aware to mention it in the docs and release notes once this gets released.

@felipetoffolo1
Copy link
Contributor Author

@marcelveldt I thought of that first. But I was not sure about adding a breaking change. If we are fine with that I'm happy to change

I think its fine as we are still early on in the cycle and this feature is not very known. Let's just make it work great instead of half baken. We should just be aware to mention it in the docs and release notes once this gets released.

@marcelveldt sounds good, let know what you think of it. Happy to rename anything if you want it

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@OzGav
Copy link
Contributor

OzGav commented Nov 24, 2024

This will be a great update! Thanks @felipetoffolo1

@skavan
Copy link

skavan commented Nov 28, 2024

wait - so https://myurl:xxxx/#/playlists?frameless=true&targetPlayer=MyBasementPlayer will give me the playlist window, without the media player and the menu bar?

THIS-IS-HUGE.
When will it be released into the beta?
If I could beg for one more addendum:
?OnlyShowFavorites=true&sort=playcount&view=list&toggleAlbumArtist=true
This isn't to replace the icons on the view, but to preselect the defaults that the user wants to see, without additional clicks.

At this point, you have effectively made MA totally modular.
The 'views' will still be your opinionated views (which are responsive and great) -- but we will be able to do almost anything within HA without having dedicated MA-HA cards. Awesome.

s.

@marcelveldt marcelveldt merged commit e5350f1 into music-assistant:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants