Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Ambitus with Flat Caps instead of Round Caps #7210

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

cbjeukendrup
Copy link
Contributor

Draw Ambitus with Flat Caps instead of Round Caps, to match normal ledger lines and stems.

Schermafbeelding 2021-01-09 om 14 53 32

This is of course needed for the master branch too. Should I make a separate PR for that or can it be cherry-picked?

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@cbjeukendrup
Copy link
Contributor Author

The test failure is as expected. Should I do anything to update the tests?

@ecstrema
Copy link
Contributor

ecstrema commented Jan 9, 2021

the vtest compare against master, so you shouldn`t have to do anything.

@igorkorsukov igorkorsukov added the vtests This PR produces approved changes to vtest results label Jan 10, 2021
@cbjeukendrup
Copy link
Contributor Author

Interesting that the vtests still fail despite the label. Apparently the condition here is not working for some reason...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants