[MU3] Fix #314935 - Adding instruments on top of others whose parts have be… #7209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/314935
When adding/removing or changing the order of staves, for all
Excerpts
the track mapping betweenExcerpt
andmasterScore
must be updated but the original implementation had some flaws.MuseScore::editInstrList()
which also adds/removes staves. However this adding/removing was done via the "undo" mechanism, the rebuild if the mapping was't.PR #7029 moved the rebuild of the mapping inside the "undo" class
SortStaves()
which used when the order of the staves was changed.This PR moves the rebuild of the mapping into a nwe "undo" class
MapExcerptTracks()
and insideMuseScore::editInstrList()
a new instance of the class is created and added to the undo stack. As a result, the mapping will always adapted to the new staff order.