Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #314910: Cutaway courtesy clefs in 3.6 don't show before time sig… #7196

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Dec 31, 2020

…natures

Resolves: https://musescore.org/en/node/315014

Fixes cutaway courtesy clefs not showing when the EndBarLine segment is not the last segment in the measure. (This happens when there is a time signature or a key signature in next measure, generating timesig/keysig Courtesy segments)

This is an improvement to functionality introduced in PR #6461.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [NA] I created the test (mtest, vtest, script test) to verify the changes I made

@elerouxx elerouxx force-pushed the cutaway-clefs-followup-3.x branch from 74e00df to c2abccd Compare January 1, 2021 22:12
@vpereverzev vpereverzev merged commit e108098 into musescore:3.x Jan 11, 2021
@MarcSabatella
Copy link
Contributor

I don't know that it is this change in particular, but somehow I do suspect the new code for handling courtesy clefs with respect to cutaway might be responsible for https://musescore.org/en/node/315861. See my comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants