fix #314633: inconsistent stem directions on middle-line beamed notes #7141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/314633 This code has been around a long time and does what it sets out to do, but there seems to be agreement it isn't desired. When setting the stem direction for two note beam groups where both notes are on or equidistant from the middle line, we look to a previous beam group to set the stem direction, rather than just always pointing down like we do for single notes on the middle line or larger beamed groups. Fix consists of removing that code.
|
Turns out there were a few tests that already covered this case. I believe I have fixed the refs for the mtests that failed, hopefully that passes this time. But the vtest beams-16 is expected to fail now, the beamed pair on the third beat of the second measure is one of the cases this code was causing to have stems up for not really a good reason. |
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 5, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/314633
This code has been around a long time and does what it sets out to do,
but there seems to be agreement it isn't desired.
When setting the stem direction for two note beam groups
where both notes are on or equidistant from the middle line,
we look to a previous beam group to set the stem direction,
rather than just always pointing down like we do for
single notes on the middle line or larger beamed groups.
Fix consists of removing that code.
vtest added.