Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(3.x) Fix MinGW parens code warnings (follow up PR #6461) #7131

Merged
merged 1 commit into from
Dec 22, 2020
Merged

(3.x) Fix MinGW parens code warnings (follow up PR #6461) #7131

merged 1 commit into from
Dec 22, 2020

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Dec 21, 2020 •
edited
Loading

FOLLOW UP to PR #6461
Resolves warning about recommended parenthesis in the code while building with MinGW.
(warning: suggest parentheses around '&&' within '||')

Cleaned up code and improved formatting in barline.cpp at 392-398

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [N] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N] I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Doesn't help, same warning still

@elerouxx elerouxx marked this pull request as draft December 21, 2020 10:58
@elerouxx elerouxx force-pushed the cutaway-6461-followup-3.x branch from a2570dc to 23bd189 Compare December 21, 2020 12:00
@elerouxx elerouxx marked this pull request as ready for review December 21, 2020 12:04
@elerouxx elerouxx force-pushed the cutaway-6461-followup-3.x branch from 23bd189 to 4b71ab3 Compare December 21, 2020 12:10
Jojo-Schmitz
Jojo-Schmitz approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this does solve the MinGW compiler warning.

@elerouxx
Copy link
Contributor Author

I can confirm that this does solve the MinGW compiler warning.

Thanks a lot for your help on this

@elerouxx elerouxx mentioned this pull request Dec 21, 2020
Closed
@vpereverzev vpereverzev merged commit ed45ac4 into musescore:3.x Dec 22, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
@igorkorsukov
ported musescore#7131: Fix MinGW parens code warnings
b4661f7
@igorkorsukov igorkorsukov mentioned this pull request Feb 2, 2021
Merged
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
@igorkorsukov
ported musescore#7131: Fix MinGW parens code warnings
20399b1
igorkorsukov added a commit that referenced this pull request Feb 2, 2021
@igorkorsukov
ported #7131: Fix MinGW parens code warnings
0f01722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elerouxx @Jojo-Schmitz @vpereverzev