Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palettes search refinements #7108

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: #6944 (comment)

  • Add padding to text field to avoid collision from search text with stop search button;
  • Pressing the Escape key from the search field will now do the same as the stop search button.
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

- Add padding to text field to avoid collision from search text with stop search button;
- Pressing the Escape key from the search field will now do the same as the stop search button.
@vpereverzev vpereverzev merged commit 0011aac into musescore:3.x Dec 19, 2020
@cbjeukendrup cbjeukendrup deleted the 3.x-palettes-refinements branch December 19, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants