Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Improvement vertical staves adjustment #7068

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Dec 11, 2020

Corrects five issues:

  1. Handle the gap above the first staff as fixed gap with a fixed staffUpperBorder spacing.
  2. Transfer of extra bracket/brace space to gap between systems. This ensures the gap between staves always use the greatest factor.
  3. Prevent adding extra space in phase 2 (make gaps between staves as equal as possible) to first staves only. Now, if the space is left, phase 2 stops and leave it to phase 3 (divide remaining evenly (wih taking the factors into account) over all gaps.
  4. When a page was edited, all following pages were laid out again, causing a performance issue on large scores.
  5. An optimisation in the second phase of the vertical staves adjustment prevent adding extra space to gaps which don't needed.

Resolves: https://trello.com/c/lAsD7xUf/59-distorted-spacing-between-topmost-pair-of-staves-on-some-pages

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

MarcSabatella and others added 3 commits December 13, 2020 13:40
…ributeStaves().

Because of this, it is no longer required to do a full layout of all pages after editing.
1) Handle the gap above the first staff as fixed gap with a fixed staffUpperBorder spacing.
2) Transfer of extra bracket/brace space to gap between systems. This ensures the gap between staves always use the greatest factor.
3) Prevent adding extra space in phase 2 (make gaps between staves as equal as possible) to first staves only. Now, if the space is left, phase 2 stops and leave it to phase 3 (divide remaining evenly (wih taking the factors into account) over all gaps.
@vpereverzev vpereverzev merged commit de79bd8 into musescore:3.x Dec 14, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 11, 2021
@njvdberg njvdberg deleted the first-gap-spacing branch March 10, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants