Symbols fixes #7063
Merged
Symbols fixes #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpereverzev
force-pushed
the
symbols_fixes
branch
from
be9b13a to
4b58b75
Compare
| @@ -2913,7 +2913,7 @@ class Sym { | |||
| public: | |||
| Sym() { } | |||
|
|
|||
| bool isValid() const { return _code != -1; } | |||
| bool isValid() const { return _code != -1 && _bbox.isValid(); } | |||
There was a problem hiding this comment.
This check seems to have broken the ability to add the space character from the Special Characters dialog. Not sure if this check was necessary, or if there is perhaps a way to give space a valid bbox, or if we could just exempt space from the check
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 5, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: