Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Labeling solo parts #7055

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Dec 9, 2020

Resolves: https://trello.com/c/piTSKoq2/28-solo-instrument-names-should-end-in-solo-eg-flute-solo-soprano-solo

Solves two issues in two different commits:

  1. When creating a new score, Soloists wasn't store in the part.
  2. New instrument numbering, renumbers instruments and soloists independently.
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@njvdberg njvdberg force-pushed the labeling-solo-parts branch from a5778bd to aaa839d Compare December 9, 2020 14:36
@vpereverzev vpereverzev merged commit 8c30d15 into musescore:3.x Dec 10, 2020
@njvdberg njvdberg deleted the labeling-solo-parts branch March 10, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants