Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #313420 [MusicXML] Instrument brackets are all imported at column 0 #7001

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

AntonioBL
Copy link
Contributor

Resolves: https://musescore.org/en/node/313420

System bracket implementation was changed between MuseScore 2.x and 3.x, but it was never updated in the MusicXML import.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@AntonioBL
Copy link
Contributor Author

There was a problem with Create_New_Score.mscz during rebase.
I will try to amend it.

@AntonioBL
Copy link
Contributor Author

Now the rebase conflict is solved.
That mscz file messed a little with the git history of my branch.

@Jojo-Schmitz
Copy link
Contributor

Blame it on @njvdberg ;-)

@njvdberg
Copy link
Contributor

njvdberg commented Dec 3, 2020

Blame it on @njvdberg ;-)

I just opened a new packet with brown bags, shall I one or two for myself? 😉

@vpereverzev vpereverzev merged commit 8c98ded into musescore:3.x Dec 4, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 17, 2021
vpereverzev pushed a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants