Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Harp and braces #6960

Merged
merged 2 commits into from
Nov 29, 2020
Merged

[MU3] Harp and braces #6960

merged 2 commits into from
Nov 29, 2020

Conversation

njvdberg
Copy link
Contributor

Resolves: https://trello.com/c/iVfSQodt/15-harp-has-all-the-brackets

Solves a bug preventing generating square braces for an instrument having multiple staves.
Next moved the harp to a dedicated family for the Orchestra score order.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@njvdberg njvdberg changed the title Harp and braces [MU3] Harp and braces Nov 28, 2020
@vpereverzev vpereverzev merged commit 397068c into musescore:3.x Nov 29, 2020
@njvdberg njvdberg deleted the harp-braces branch March 10, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants