Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Fixes for the Style and Preferences dialogs #6958

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Nov 28, 2020

  • Fix tab order in Edit Style dialog
  • Fix #312195: Style dialog loses setting of chord symbol radio buttons (replaces and improves @MarcSabatella's PR fix #312195: style dialog loses setting of chord symbol radio buttons #6954)
  • Fix #306644: Preferences window doesn't match on a 15'' Laptop screen and height isn't resizeable
  • Reducing hight of Preferences dialog further by using grid layouts for the Note Input and Import tabs.
    Also fixing the tab order.
  • Reducing height of the Edit Style dialog by reorganizing the Measure part of the dialog.
    Limiting factor now being the the top entry, the Score settings

@Jojo-Schmitz Jojo-Schmitz changed the title Fix tab order in Edit Style dialog [MU3] Fix tab order in Edit Style dialog Nov 28, 2020
@Jojo-Schmitz Jojo-Schmitz force-pushed the edit-style-chord-symbols branch from 9b097f5 to f82a81c Compare November 28, 2020 09:25
@Jojo-Schmitz Jojo-Schmitz changed the title [MU3] Fix tab order in Edit Style dialog [MU3] Fix #312195: Style dialog loses setting of chord symbol radio buttons and fix tab order in Edit Style dialog Nov 28, 2020
@Jojo-Schmitz Jojo-Schmitz force-pushed the edit-style-chord-symbols branch from 09c3098 to 0bcaf25 Compare November 28, 2020 11:36
@Jojo-Schmitz Jojo-Schmitz changed the title [MU3] Fix #312195: Style dialog loses setting of chord symbol radio buttons and fix tab order in Edit Style dialog [MU3] Fixes for the Style and Preferences dialogs Nov 28, 2020
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 28, 2020

With @Tantacrul's official blessing (ff.), this is now how it looks
Preferences-Canvas-after2

@Jojo-Schmitz Jojo-Schmitz force-pushed the edit-style-chord-symbols branch from f513221 to 2b34b24 Compare November 29, 2020 07:56
@Jojo-Schmitz
Copy link
Contributor Author

Reducing the height of the Preferences dialog even further, by using a grid layout for the Note Input and Import tabs:
Preferences-Note_Input-after
Preferences-Import-after

@Jojo-Schmitz
Copy link
Contributor Author

(Slighly) reducing the height of the Edit Style dialog by reorganizing the Measure part:
Edit_Style-Measure-after
Limiting factor for further reduction is the Score part:
Edit_Style-Score
Esp. the "Indent on first system" had been discussed to get moved to the System part of the dialog, this would help here, but discussion about that hasn't come to a conclusion yet:

@Tantacrul
Copy link
Contributor

Fixes some issues with screens at small sizes.

@Jojo-Schmitz
Copy link
Contributor Author

Yes, amongst other things

@Jojo-Schmitz
Copy link
Contributor Author

The vtest fails need #6965

By using grid layouts for the Note Input and Import tabs.
Also fixing the tab order.
by reorganizing the Measure part of the dialog.
Limiting factor now being the the top entry, the Score settings
@Jojo-Schmitz Jojo-Schmitz force-pushed the edit-style-chord-symbols branch from 99e98f5 to a232da9 Compare November 29, 2020 19:37
@vpereverzev vpereverzev merged commit 5970a17 into musescore:3.x Nov 30, 2020
@Jojo-Schmitz
Copy link
Contributor Author

No idea what or how much of this would apply to master, so I'd rather not port it accross

@vpereverzev
Copy link
Member

@Jojo-Schmitz style dialog changes should be OK to port in master (we're using QWidget implementation so far, I can say that it'll be redesigned only in 4.1+)

Preference dialog has a new design in MU4, so it should live in MU3 only

@Jojo-Schmitz
Copy link
Contributor Author

I see. Will see what I can do, merge conflicts with UI files are very nasty and mostly impossible to fix.

@Jojo-Schmitz Jojo-Schmitz deleted the edit-style-chord-symbols branch November 30, 2020 11:43
@Jojo-Schmitz
Copy link
Contributor Author

That edit style dialog has already diverged a lot, none of my changes here seem to make any sense there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants