[MU3] Make AutoSize default for new scores but disable it for older scores.

[njvdberg]

Resolves: https://trello.com/c/11WgLsL1/23-disabling-vertical-frame-enable-auto-size-is-not-saved-in-score-file

In the VBox::VBox() constructor, the variable _isAutoSizeEnabled was always set to true for score with a version number >= 3.02. However, the default for that property is false. So, when this option was switched of, the property has the default value and isn't written into the score file. Next, when reading the file, there no such property but if the score version was >= 3.02, the property was set to true again.

This is solved by setting the default of _isAutoSizeEnabled to true. But when reading an score < 3.02, this property in set to false after reading the properties in Box::read(). Also, Box::getProperty() will always return false for older scores.

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• I created the test (mtest, vtest, script test) to verify the changes I made

[RobFog]

"disables" should "disable"?

[Jojo-Schmitz]

One vtest diff, before:

after

So a matter of title frame size I guess

[Jojo-Schmitz]

That vtest fail might be easily fixed by updating the scorefile it stems from I guess?

[njvdberg]

The vtest violation was caused by reading a 2.x file. In both read114.cpp and read206.cpp the auto resize had to be disabled explicitly.

[Jojo-Schmitz]

Now, mtests fail (and macos uploading artifacts)

[njvdberg]

Now, mtests fail (and macos uploading artifacts)

The mtest was my mistake, the files got a new tag.
But why uploading artifact fails every now and then puzzles me. It seems to something in the system, not in the sources.

[Jojo-Schmitz]

yes, likely not your fault