Ease in out gliss graph #6945
Merged
Ease in out gliss graph #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscore/easeinoutcanvas.cpp
Outdated
| //============================================================================= | ||
|
|
||
| #include "easeinoutcanvas.h" | ||
| #include "..\libmscore\easeInOut.h" |
There was a problem hiding this comment.
I think you can and should drop that ..\ and should change \ to /
Guess that is the reason why it fails to build on Mac and Linux
There was a problem hiding this comment.
Looks much better now ;-)
ypoissant
force-pushed
the
EaseInOutGlissGraph
branch
from
b63d107 to
8e30ae8
Compare
The time event warp graph shows the effect of tuning ease-in and ease-out of time warping on the pitch event in the glissando inspector. The number of pitch event is computed by the same function used to decide which pitches to MIDI render.
ypoissant
force-pushed
the
EaseInOutGlissGraph
branch
from
8e30ae8 to
876fcda
Compare
|
I just did a rebase and fixed a few bracket indentations. This is ready for code review. |
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 12, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added pitch warp graph is useful for previewing the effect of adjusting ease-in and ease-out sliders on the timing of pitch events in a glissando.
Given the start and end note of the glissando and the glissando style, the graph displays each of the glissando style pitch at their proper timing. The timing is warped according to the ease-in and ease-out values. A time warp transfer curve is displayed over the pitch graph and a note scale is displayed in the left side border.
The pitch graph is updated interactively as the ease-in and ease-out sliders are adjusted.
Note that because the first PR have not been merged, the diff currently shows all the changes including the changes that were already code reviewed in PR #6868