Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3] Add an <unsorted> section to the default <custom> score order. #6943

Merged
merged 1 commit into from
Nov 29, 2020
Merged

[MU3] Add an <unsorted> section to the default <custom> score order. #6943

merged 1 commit into from
Nov 29, 2020

Conversation

njvdberg
Copy link
Contributor

Resolves: https://trello.com/c/HgpFok0n/36-when-custom-ordering-is-selected-adding-instruments-causes-a-crash

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Nov 26, 2020 •
edited
Loading

I hope it is custom, not custum...

@njvdberg njvdberg mentioned this pull request Nov 26, 2020
Closed
@chenlung
Copy link
Contributor

Also ‘section’

@njvdberg njvdberg changed the title [MU3] Add an <unsorted> secion to the default <custum> score order. [MU3] Add an <unsorted> secion to the default <custom> score order. Nov 26, 2020
@njvdberg
Copy link
Contributor Author

I hope it is custom, not custum...

Me too 😉 But luckily it is.

@njvdberg njvdberg changed the title [MU3] Add an <unsorted> secion to the default <custom> score order. [MU3] Add an <unsorted> section to the default <custom> score order. Nov 26, 2020
@njvdberg
Copy link
Contributor Author

Also ‘section’

Luckily all the mistakes are in the title 😄

@vpereverzev vpereverzev merged commit 08e8957 into musescore:3.x Nov 29, 2020
@njvdberg njvdberg deleted the CustomCrash branch March 10, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njvdberg @Jojo-Schmitz @chenlung @vpereverzev