Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] FirstSystemIndentation taking care lenght instrument labels #6941

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

njvdberg
Copy link
Contributor

Resolves: https://trello.com/c/055jGzml/13-first-system-indentation-should-not-apply-where-instrument-labels-are-present

First system indentation now takes the maximum of the length of the instruments labels and the style parameter firstSystemIndentationValue. The maximum value of this parameter is now exceeded to 1000.0 which is the same maximum used in other parameters.

SectionBreak also generates a first system indentation but this can be enabled/disabled per SectionBreak.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@njvdberg njvdberg changed the title FirstSystemIndentation taking care lenght instrument labels [MU3] FirstSystemIndentation taking care lenght instrument labels Nov 26, 2020
…nstruments labels and the style parameter firstSystemIndentationValue. The maximum value of this parameter is now exceeded to 1000.0 which is the same maximum used in other parameters.

SectionBreak also generates a first system indentation but this can be enabled/disabled per SectionBreak.
@chenlung
Copy link
Contributor

Typo: ‘length’

@vpereverzev vpereverzev merged commit 4983887 into musescore:3.x Nov 29, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 8, 2021
vpereverzev pushed a commit that referenced this pull request Feb 8, 2021
@njvdberg njvdberg deleted the FirstStaffIndent branch March 10, 2021 12:47
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 19, 2024
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 10, 2024
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants