Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Partial fix #279707: First steps towards automatic updates on Linux #6919

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Nov 24, 2020

Partially resolves: https://musescore.org/en/node/279707

Creates a zsync delta update file for AppImages but doesn't yet upload it to a server as this has to be done by @igorkorsukov or another member of the in-house team.

For now, updates require an external tool like AppImageUpdate or AppImageLauncher, but if it works as expected then we can bundle a tool within MuseScore like we do with Sparkle on macOS.

See https://github.com/AppImage/AppImageSpec/blob/master/draft.md#update-information

Next steps to enable automatic updates...

Stable releases

Simply upload the zsync file to GitHub releases alongside the AppImage. The autoupdate software understands GitHub and will query the GitHub API to find the latest stable version.

Nightly builds

The autoupdate software doesn't know anything about OSUOSL, so the AppImage and zsync files MUST be made available at the following exact URLs:

Here "latest" is a fixed string, NOT a variable!!!

Whenever a new nightly build is uploaded on the 3.x branch, it must replace the old one at that same URL. Of course we want to keep historic nightlies available, so you should upload nightlies to version-dependent URLs like now and then make a symlink / redirect / physical copy of the latest one at the above URL. See PR #4757 for a suggestion of how to do this.


  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

Creates a zsync delta update file for AppImages but doesn't yet upload
it to a server.
Comment on lines +65 to +66
echo "ZSYNC_FILE: $ZSYNC_FILE" # TODO: Upload to server alongside AppImage
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since BUILD_MODE=devel_build for PRs, this echo doesn't appear in the build log for this PR on GitHub Actions.

@shoogle shoogle changed the title Partial fix #279707: First steps towards automatic updates on Linux [MU3] Partial fix #279707: First steps towards automatic updates on Linux Nov 24, 2020
@igorkorsukov igorkorsukov merged commit e452b3a into musescore:3.x Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants