Improves recognition of instrument when loading a pre-3.6 score. #6891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvdberg
force-pushed
the
ScoreOrderingBrace
branch
from
87c6491 to
2f0d27c
Compare
In case the instrument in the score file has MusicXMLid with value "strings.group", the value of controller 132 is used to find the correct strings group. This prevent all "Violons", "Violas", "Violoncellos" and "Contrabasses" are mapped onto "Strings" which causes wrong brackets to be generated. Also solves a few sorting issues.
njvdberg
force-pushed
the
ScoreOrderingBrace
branch
from
2f0d27c to
8345c36
Compare
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…g a pre-3.6 score.
vpereverzev
pushed a commit
that referenced
this pull request
Feb 4, 2021
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…g a pre-3.6 score.
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…g a pre-3.6 score.
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 4, 2021
…g a pre-3.6 score.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://trello.com/c/lXc1BqEB/18-imagepng
In case the instrument in the score file has MusicXMLid with value
strings.group, the value of controller 132 is used to find the correct strings group. This prevents allViolons,Violas,VioloncellosandContrabassesare mapped ontoStringswhich causes wrong brackets to be generated.