[MU3] Porting some master changes/PRs to 3.x #6889
Conversation
Jojo-Schmitz
commented
Nov 19, 2020
Jojo-Schmitz
commented
- fix #98816 - wrong tie direction in tabs #6442 - Fix #98816 and fix #117351: Decouple tie direction from _notes order, and compare strings (not lines) in tabs
- fix #277800: allow to preserve ties when replacing measures (by removing and inserting them) #5566 - Fix #277800: Allow to preserve ties when replacing measures (by removing and inserting them)
… and compare strings (not lines) in tabs
…ing and inserting them)
|
vtest failure seems to be expected because of #6442 |
|
Actually, there are differences in the vtests due to this PR also in normal ties case. In principle this should not have happened. And with this PR: |
Oh, wow. It's a weird result, we need to fix this or even either revert these particular changes |
There was a problem hiding this comment.
@vpereverzev @AntonioBL I think the problem was caused by this error in porting
by the way @Jojo-Schmitz thank you for creating this PR, saved me some time 👍
| tieAbove = notes[i]; | ||
| else if (compareNotesPos(notes[i], tieAbove) < 0) | ||
| tieAbove = notes[i]; | ||
| else if (noteDiff < 0) { |
There was a problem hiding this comment.
if (noteDiff > 0) should close before the else if (noteDiff < 0) block starts
There was a problem hiding this comment.
I might have removed a couple braces too much I guess...
|
@Git-Lior nice to see you around! Are you able to prepare a quick-fix then? |
|
Check #6892 |
