Fix 308242: Elements that need fixing with Staff Type Changes

[elerouxx]

Resolves: https://musescore.org/en/node/308242
https://musescore.org/en/node/290157
and https://musescore.org/en/node/307905

This PR fixes a number of issues with some elements and Staff Type Changes. (Most of the fixes required just adjusting the vertical position to the right staffType yOffset and stepOffset.)

Before:

After:

Ledger Lines

• Now generate correctly after top/bottom staff line and stepOffset (chord.cpp)
• Now follow staffType yOffset (ledgerline.cpp)

Slurs

• Now follow staffType yOffset

Ties

• Now follow staffType yOffset
• Most generated ties (by pasting, changing note duration, etc) didn't have a tick set at creation time, so I went thru all them to set Tick to startNote->tick() (and when possible Tick2 to endNote->tick() ) on tie creation (in cmd.cpp, note.cpp, noteentry.cpp, paste.cpp, edit.cpp).

Before the fix:

Clefs

• Now stay at the right line when using more or less than 5 staff lines.
• Now are adjusted to mark the right pitch after stepOffset
• Percussion and tab clefs now ignore stepOffset (since they don't indicate a pitch) so they stay vertically centered to the staff.

Key Signatures

• Adjusted to follow stepOffset so they stay at right pitches

Repeat barlines

• Now the dots stay properly centered to the staff with an yOffset

Line

• Adjusted y pos to follow staffType yOffset (line.cpp)
• Adjusted anchor lines to reflect staffType yOffset (genericDragAnchorLines in element.cpp)

text line

• Adjusted to follow yOffset (textlinebase.cpp)
• Adjusted anchor lines (same as above)

Text

• Adjusted to follow yOffset
• Adjusted anchor lines (same as above).

Before the fix:

Click note entry

• Clicking to add notes on a changed staff Type now adds the note in the intended line/space, recalculated after the staffType yOffset, stepOffset and lineDistance. (noteentry.cpp)

Grace Notes

• Now follow staff Type yOffset

Lyrics

• Added staff yOffset to Lyrics lines so they stay aligned to lyrics. (lyricsline.cpp)

Compute Up/down:

• Now the staff middleLine is calculated including stepOffset, so beams and other elements have the right direction.

Additional notes (for a future PR):

• Symbols and images added to barlines do not to adjust to yOffset (they do when added to chord/rests). Should they?
• Skylines: check on how rects are added to it on a staff type change with an offset (Maybe don't need a fix - in any case seems too complex to include here)
• Some articulations like the accent follow stepOffset correctly, but staccato and dash (tenuto) don't. Need further checking on this.
• Some elements like dynamics seem to 'overdo' automatic placement along with the staffType Offset. Needs deeper checking (not in this PR for the time being).

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• [NA] I created the test (mtest, vtest, script test) to verify the changes I made

[elerouxx]

I just indented these two lines, but - innocent question: why can't we just tie->setTick(note->tick()) ?

[elerouxx]

There are some places on the code that compute positions and autoplacing from the unchanged staff height boundaries. This could be adapted to the real staffType(tick) boundaries but that would be a separate PR.

[elerouxx]

This code recalculates the click position on a modified staff so the note is added to the intended (clicked) line or space. (Testing for any other input method that implies clicking or could be affected by this code.)