Fix #297482 - Score layout shifts when saved with fingering on acciaccatura #5822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…catura
Resolves: https://musescore.org/en/node/297482#comment-984598
Solves the shift of the fingering on the grace note, and therefor the shift of the line above the fingering.
The root cause was
StemSlash
. Shapes for theStemSlash
are created during the layout of the beams of the grace notes and the layout of these beams is with the layout of the completeChord
to which the grace notes belong. As a result, the shapes ofStemSlash
are added to the skyline after the layout of theFingering
so the layout of theFingering
was based of the layout of theStem
only.After a re-layout the
StemSlash
is included in the skyline so the re-layout will movethe Fingering and, in this case, also the line.
The solution was a extra layout of the
StemSlash
inScore::layoutChords3()
so itsStemSlash
is included in the skyline in time.Although this issue is very similar to #302316 and fix #297501, the root cause is different.