-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adjusted bar numbers to the status bar, if they differ #5071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! This all looks like it should do the trick. Just a few points, mainly code style.
a) for my taste there a a couple too many curly braces, not really needed for single statement if or else |
|
|
MuseScore coding style: "Use curly braces when the body of a conditional statement contains more than one line, and also if a single line statement is somewhat complex. Otherwise, omit them." |
and IMHO none of them here quaify as "somewhat complex" |
Well, sure, but all I'm saying is that if I were merging PRs, I wouldn't prevent a PR from being merged because the braces weren't perfect. |
Thanks for changing it Josh! Just one last thing, if you could squash the two commits into a single commit and change the commit message to include the issue number, that'd be great. For example:
|
and work on the 'simplify translations' issue I mentioned? |
38a306c
to
fecee1b
Compare
rebase needed (also needs the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would also need to discuss how to best present this in the screen reader info.
Looking for rebase (probably on 3.x) |
Archived due to inactivity (we can return it to active PRs when the author returns) |
This implements some of the suggestions in https://musescore.org/en/node/288968. I haven't yet changed the find function to implement searching for these adjusted bar numbers, as I think there would have to be a significant rewrite of the parsing of that, in order to allow the user to specify bar numbers in a specific section, and I think that should have its own pull request. What this does do, though, is change the status bar text to include the adjusted bar number, if it differs from the absolute bar number. It does this in the format
adjusted bar number (absolute bar number)
.