FIX #11220: enable jack by default #21861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrra
changed the title
Jojo-Schmitz
reviewed
Mar 8, 2024
lyrra
force-pushed
the
enable-jack-audio
branch
2 times, most recently
from
eec6cab to
efe1e48
Compare
lyrra
force-pushed
the
enable-jack-audio
branch
from
efe1e48 to
12b56f0
Compare
lyrra
force-pushed
the
enable-jack-audio
branch
from
12b56f0 to
d4f6d90
Compare
lyrra
force-pushed
the
enable-jack-audio
branch
8 times, most recently
from
62fc361 to
828bb8e
Compare
* include linuxaudiodriver * include-guard * deviceid clash * mu::audio -> muse::audio rename
lyrra
force-pushed
the
enable-jack-audio
branch
4 times, most recently
from
264aa0d to
dfc2967
Compare
igorkorsukov
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve many of #11220
Resolves the problem of exclusive access to alsa.
And makes the most common workaround superfluous (a workaround where an emulated alsa device is setup in users .asoundrc that routes to pulseaudio/jack/pipewire).
By having an jack-api enabled we can speak directly to jack, or route to pipewire.
Midi out still needs to be emulated (or go directly to alsa).