Update ytdl-core Dependency and Rebuild

.github/workflows/lint.yml

@@ -7,14 +7,20 @@ jobs:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-        - uses: actions/checkout@v1
-        - uses: actions/setup-node@v2
-          with:
-            node-version: '18'
-            cache: 'yarn'
-        - name: Install dependencies
-          run: yarn install
-        - name: Generate Prisma client
-          run: yarn prisma generate
-        - name: Run lint
-          run: yarn lint
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'yarn'
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Generate Prisma client
+        run: yarn prisma generate
+
+      - name: Run lint
+        run: yarn lint

.github/workflows/type-check.yml

@@ -7,14 +7,20 @@ jobs:
     name: Type Check
     runs-on: ubuntu-latest
     steps:
-        - uses: actions/checkout@v1
-        - uses: actions/setup-node@v2
-          with:
-            node-version: '18'
-            cache: 'yarn'
-        - name: Install dependencies
-          run: yarn install
-        - name: Generate Prisma client
-          run: yarn prisma generate
-        - name: Run type check
-          run: yarn tsc
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'yarn'
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Generate Prisma client
+        run: yarn prisma generate
+
+      - name: Run type check
+        run: yarn tsc

Dockerfile

@@ -1,10 +1,14 @@
-FROM node:18-bullseye-slim AS base
+FROM node:22-bullseye-slim AS base
 
 # openssl will be a required package if base is updated to 18.16+ due to node:*-slim base distro change
 # https://github.com/prisma/prisma/issues/19729#issuecomment-1591270599
 # Install ffmpeg
 RUN apt-get update \
     && apt-get install --no-install-recommends -y \
+    build-essential \
+    python3 \
+    python3-distutils \
+    python3-venv \
     ffmpeg \
     tini \
     openssl \
@@ -13,6 +17,8 @@
     && apt-get autoremove \
     && rm -rf /var/lib/apt/lists/*
 
+ENV PYTHON /usr/bin/python3
+
 # Install dependencies
 FROM base AS dependencies
 

package.json

@@ -89,7 +89,7 @@
     "@discordjs/opus": "^0.8.0",
     "@discordjs/rest": "1.0.1",
     "@discordjs/voice": "0.17.0",
-    "@distube/ytdl-core": "^4.15.9",
+    "@distube/ytdl-core": "^4.16.2",
     "@distube/ytsr": "^2.0.4",
     "@prisma/client": "4.16.0",
     "@types/libsodium-wrappers": "^0.7.9",

src/services/player.ts

@@ -665,17 +665,23 @@ export default class {
     }
   }
 
-  private async createReadStream(options: {url: string; cacheKey: string; ffmpegInputOptions?: string[]; cache?: boolean; volumeAdjustment?: string}): Promise<Readable> {
+  private async createReadStream(options: {
+    url: string;
+    cacheKey: string;
+    ffmpegInputOptions?: string[];
+    cache?: boolean;
+    volumeAdjustment?: string;
+  }): Promise<Readable> {
     return new Promise((resolve, reject) => {
       const capacitor = new WriteStream();
+      let hasReturnedStreamClosed = false;
 
       if (options?.cache) {
         const cacheStream = this.fileCache.createWriteStream(this.getHashForCache(options.cacheKey));
-        capacitor.createReadStream().pipe(cacheStream);
+        capacitor.createReadStream()?.pipe(cacheStream);
       }
 
       const returnedStream = capacitor.createReadStream();
-      let hasReturnedStreamClosed = false;
 
       const stream = ffmpeg(options.url)
         .inputOptions(options?.ffmpegInputOptions ?? ['-re'])
@@ -689,13 +695,13 @@ export default class {
           }
         })
         .on('start', command => {
-          debug(`Spawned ffmpeg with ${command as string}`);
+          debug(`Spawned ffmpeg with ${command}`);
         });
 
       stream.pipe(capacitor);
 
       returnedStream.on('close', () => {
-        if (!options.cache) {
+        if (!options?.cache) {
           stream.kill('SIGKILL');
         }