Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for MIDI timestretch and fixed small bug when receiving results #1065

Merged
merged 5 commits into from
Apr 18, 2022

Conversation

StaffanMelin
Copy link
Contributor

Hi! Trying to get into MusE development, so I started with adding the requested script.

There was a bug in scripts.cpp, so when reading back the modified MIDI data from the script, all CONTROLLER events were misinitialized (tick was not read and set). I have fixed this too.

Re: #1037

@spamatica
Copy link
Member

I didn't try running the script but it looks good. Good catch on the bug!
One last thing before merging, please add a line in the ChangeLog file along the same lines as the previous entries.

@spamatica
Copy link
Member

Regarding the related ticket.
It is good to mention the ticket number (in this case #1037) in the related commit message, this way github will automatically reference the commit in the ticket.

@StaffanMelin StaffanMelin force-pushed the master branch 2 times, most recently from 0de3493 to ab68dc7 Compare April 5, 2022 20:02
@StaffanMelin
Copy link
Contributor Author

Sorry, somehow I messed up (still new to Git). Was trying to do another pull request fixing issue #1022, but somehow this got merged into the first pull request. So the changes in pianoroll.cpp are for the second fix (ie #1022).

Will this still be ok or do I have to redo it somehow?

@StaffanMelin StaffanMelin linked an issue Apr 5, 2022 that may be closed by this pull request
@spamatica
Copy link
Member

Hey hey, sorry, missed the continuation of this.
I see the other fix still there, looks trivial though so I'll go ahead and merge

@spamatica spamatica merged commit 389d08d into muse-sequencer:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Time stretching/shrinking for midi/drum parts Allow even more zoom out in piano roll
2 participants