Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasional crashes when using the revert button #21

Open
murraycu opened this issue May 29, 2016 · 2 comments
Open

Occasional crashes when using the revert button #21

murraycu opened this issue May 29, 2016 · 2 comments

Comments

@murraycu
Copy link
Owner

There are some reports via the app store's crash reporter of crashes after the user has pressed the revert button, but I cannot reproduce this myself.
@murraycu
Copy link
Owner Author

Here is the crash report, which others might be able to import into Xcode:

BjQvigluW9KYSYPLx2O2mo.xccrashpoint.zip

@murraycu
Copy link
Owner Author

Here is the backtrace:

0   CoreFoundation                  0x1822aae38 __exceptionPreprocess + 124 (NSException.m:162)
1   libobjc.A.dylib                 0x18190ff80 objc_exception_throw + 56 (objc-exception.mm:531)
2   CoreData                        0x18415cd8c -[NSManagedObjectContext deleteObject:] + 368 (NSManagedObjectContext.m:1006)
3   Galaxy Zoo                      0x10007f8f8 -[ZooniverseClient abandonSubjectInMainThread:withCoreDataSave:] + 168 (ZooniverseClient.m:1147)
4   Galaxy Zoo                      0x100087840 -[QuestionViewController resetQuestionToFirst] + 424 (QuestionViewController.m:82)
5   Galaxy Zoo                      0x1000799cc -[ClassifyViewController onButtonRevertClicked:] + 40 (ClassifyViewController.m:139)
6   UIKit                           0x18742cad0 -[UIApplication sendAction:to:from:forEvent:] + 100 (UIApplication.m:4265)
7   UIKit                           0x1875b14f4 -[UIBarButtonItem(UIInternal) _sendAction:withEvent:] + 168 (UIBarButtonItem.m:1595)
8   UIKit                           0x18742cad0 -[UIApplication sendAction:to:from:forEvent:] + 100 (UIApplication.m:4265)
9   UIKit                           0x18742ca4c -[UIControl sendAction:to:forEvent:] + 80 (UIControl.m:612)
10  UIKit                           0x187414740 -[UIControl _sendActionsForEvents:withEvent:] + 436 (UIControl.m:694)
11  UIKit                           0x18741488c -[UIControl _sendActionsForEvents:withEvent:] + 768 (UIControl.m:702)
12  UIKit                           0x18742c33c -[UIControl touchesEnded:withEvent:] + 572 (UIControl.m:446)
13  UIKit                           0x1873e4b0c _UIGestureRecognizerUpdate + 8988 (UIGestureRecognizer.m:457)
14  CoreFoundation                  0x1822607b0 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 32 (CFRunLoop.c:1620)
15  CoreFoundation                  0x18225e554 __CFRunLoopDoObservers + 372 (CFRunLoop.c:1716)
16  CoreFoundation                  0x18225e984 __CFRunLoopRun + 928 (CFRunLoop.c:2558)
17  CoreFoundation                  0x182188d10 CFRunLoopRunSpecific + 384 (CFRunLoop.c:2814)
18  GraphicsServices                0x183a70088 GSEventRunModal + 180 (GSEvent.c:2245)
19  UIKit                           0x18745df70 UIApplicationMain + 204 (UIApplication.m:3772)
20  Galaxy Zoo                      0x100084620 main + 88 (main.m:14)
21  libdyld.dylib                   0x181d268b8 start + 4 (start_glue.s:78)

murraycu added a commit that referenced this issue May 30, 2016
@murraycu
Set self.subject to nil after requesting deletion.
2f9db0f 
This might help prevent an occasional crash when pressing the revert
button, for instance if pressing it twice very quickly.
See #21
murraycu added a commit that referenced this issue May 30, 2016
@murraycu
ZooniverseClient: abandonSubjectInMainThread: Check for nil subject.
05cb6fb 
This should not happen but maybe it is happening, causing the exception
seen in the occasional crashes when pressing the revert button.
See #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murraycu