Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classify: screen doesn't rearrange correctly when rotated #10

Closed
vrooje opened this issue Aug 22, 2015 · 3 comments
Closed

Classify: screen doesn't rearrange correctly when rotated #10

vrooje opened this issue Aug 22, 2015 · 3 comments

Comments

@vrooje
Copy link

vrooje commented Aug 22, 2015

I'm using the app with my iPad; I've noticed that if I rotate my screen during the classification the new placement of the items on the screen is a little weird, such that often some of the answer choices end up off the screen. If I answer the question while rotated, the next question comes up with the correct alignment.

img_0024
img_0025
@murraycu
Copy link
Owner

Yes, rotation needs lots of attention.

For the iPhone, I might just disable rotation. I don't see how it can ever be arranged usefully in landscape on an iPhone.

@vrooje
Copy link
Author

vrooje commented Aug 22, 2015

Agreed!

murraycu added a commit that referenced this issue Sep 4, 2015
@murraycu
Info.plist (Project Settings): Disable landscape on non-iPad.
1e518e1 
We can re-enable this if we ever think of a way to arrange things
usefully on a small screen in landscape orientation.
See #10 (comment)
murraycu added a commit that referenced this issue Sep 4, 2015
@murraycu
QuestionViewController: Resize in response to rotation.
1b1ffe8 
Otherwise, the QuestionAnswersCollectionView uses cell sizes still
based on the portrait mode, when switching to landscape mode,
for instance.
This should fix this bug:
#10
@murraycu
Copy link
Owner

murraycu commented Sep 4, 2015

The problem with the button sizes and positions is fixed by commit 1b1ffe8 .

I've opened this issue about the general landscape layout on iPad:
#12
(Incidentally, there doesn't seem to be any way to stop the app being installed on iPad in the meantime.)

@murraycu murraycu closed this as completed Sep 4, 2015
murraycu added a commit that referenced this issue Sep 4, 2015
@murraycu
Classify: Subject: Constrain the top to the Top Layout Guide.
914086e 
This lets the image take up the whole available height.
This fixes the too-small image (and wasted blank space above it)
in the portrait screenshot here:
#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murraycu @vrooje