doInBackground handlers: Check for isCancelled().

Just because it is generally good practice: https://developer.android.com/reference/android/os/AsyncTask.html However, in this particular code there is no place where we can periodically check this while doing work.
murraycu · Mar 16, 2017 · ab6e3c8 · ab6e3c8
1 parent 793d942
commit ab6e3c8
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 1 deletion.
diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/ClassifyActivity.java b/app/src/main/java/com/murrayc/galaxyzoo/app/ClassifyActivity.java
@@ -160,6 +160,10 @@ protected Boolean doInBackground(final Void... params) {
                 return Boolean.FALSE;
             }
 
+            if (isCancelled()) {
+                return Boolean.FALSE;
+            }
+
             return LoginUtils.getLoggedIn(context);
         }
 
@@ -205,6 +209,10 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             final AccountManager mgr = AccountManager.get(context);
 
             //Note this needs the GET_ACCOUNTS permission on
@@ -216,12 +224,15 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             final Account account = accts[0];
 
             final Bundle extras = new Bundle();
             extras.putBoolean(ContentResolver.SYNC_EXTRAS_MANUAL, true);
 
-
             //Ask the framework to run our SyncAdapter.
             ContentResolver.requestSync(account, Item.AUTHORITY, extras);
 

diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/LoginActivity.java b/app/src/main/java/com/murrayc/galaxyzoo/app/LoginActivity.java
@@ -315,6 +315,10 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             final String accountName = loginResult.getName();
 
             final AccountManager accountManager = AccountManager.get(context);

diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/LoginUtils.java b/app/src/main/java/com/murrayc/galaxyzoo/app/LoginUtils.java
@@ -470,6 +470,10 @@ protected LoginDetails doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             LoginDetails result = null;
 
             try {
@@ -517,6 +521,10 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             final LoginUtils.LoginDetails loginDetails = LoginUtils.getAccountLoginDetails(context);
             if(!LoginUtils.getLoggedIn(loginDetails)) {
                 return null;
@@ -527,6 +535,10 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             LoginUtils.removeAccount(context, accountName);
 
             LoginUtils.addAnonymousAccount(context);

diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/QuestionFragment.java b/app/src/main/java/com/murrayc/galaxyzoo/app/QuestionFragment.java
@@ -681,6 +681,10 @@ protected Void doInBackground(final Void... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             fragment.saveClassificationSync(classificationInProgress);
 
             return null;

diff --git a/app/src/main/java/com/murrayc/galaxyzoo/app/Singleton.java b/app/src/main/java/com/murrayc/galaxyzoo/app/Singleton.java
@@ -318,6 +318,10 @@ protected Void doInBackground(final Context... params) {
                 return null;
             }
 
+            if (isCancelled()) {
+                return null;
+            }
+
             final Context context = params[0];
             try {
                 Singleton.ourInstance = new Singleton(context);