build: drop SDL1 support + use pkg-config for SDL2 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL1 is unmaintained upstream and using it only leads to a degraded experience. Especially when it recives far less testing.
SDL2 hasn't required suing sdl2-config in a long time and using pkg-config can have better results for distros.
Closed
4 tasks
There's quite a bit of code that can be reworked in vidext.c if it's fine to drop SDL1 support completely, I can get to that if @richard42 is fine with dropping it. On a semi-related note, I want to get SDL3 support in eventually too, so dropping SDL1 would help with that work. |
|
yes, let's move forward with this. Please pull out the SDL1 code from the video extension as well. |
Merged
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 3, 2024
Also removes undocumented dependency on which(1). Upstream-PR: mupen64plus/mupen64plus-core#1093 Upstream-Commit: mupen64plus/mupen64plus-core@966a5df Upstream-Commit: mupen64plus/mupen64plus-core@b007759 Upstream-Commit: Rosalie241/RMG@4cd4f4c Signed-off-by: orbea <[email protected]>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 9, 2024
Also removes undocumented dependency on which(1). Upstream-PR: mupen64plus/mupen64plus-core#1093 Upstream-Commit: mupen64plus/mupen64plus-core@966a5df Upstream-Commit: mupen64plus/mupen64plus-core@b007759 Upstream-Commit: Rosalie241/RMG@4cd4f4c Signed-off-by: orbea <[email protected]>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 9, 2024
Also removes undocumented dependency on which(1). Upstream-PR: mupen64plus/mupen64plus-core#1093 Upstream-Commit: mupen64plus/mupen64plus-core@966a5df Upstream-Commit: mupen64plus/mupen64plus-core@b007759 Upstream-Commit: Rosalie241/RMG@4cd4f4c Signed-off-by: orbea <[email protected]>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Nov 15, 2024
Also removes undocumented dependency on which(1). Upstream-PR: mupen64plus/mupen64plus-core#1093 Upstream-Commit: mupen64plus/mupen64plus-core@966a5df Upstream-Commit: mupen64plus/mupen64plus-core@b007759 Upstream-Commit: Rosalie241/RMG@4cd4f4c Signed-off-by: orbea <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 26, 2024
Also removes undocumented dependency on which(1). Upstream-PR: mupen64plus/mupen64plus-core#1093 Upstream-Commit: mupen64plus/mupen64plus-core@966a5df Upstream-Commit: mupen64plus/mupen64plus-core@b007759 Upstream-Commit: Rosalie241/RMG@4cd4f4c Signed-off-by: orbea <[email protected]> Signed-off-by: Eli Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a benefit this avoids
which(1)as a dependency whenPKG_CONFIGis explicitly set by the user as is the case with some distros.