Backport mupen64plus-libretro-nx dynarec fix for OoTMM randomizer #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Been wanting to upstream that for ages but @Gillou68310 wanted that to work for all interpreter types too and we never verified that |
|
Ah, that is fair. I don't have the knowledge to do that myself, but at least it's documented now, as I previously tried to find it and there was nothing at all ^^ |
|
I did it originally for @LuigiBlood 's DD shenanigans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, currently https://ootmm.com/ works with said libretro core but crashes when transitioning between games with upstream m64p. I narrowed it down to this commit: libretro/mupen64plus-libretro-nx@9cbe0fe
With this change I can confirm it switches without crashes:
Screencast.from.2024-07-05.18-26-14.webm
Disclaimer: I don't know if it makes sense, this is their commit unchanged (except for code style fixes)