Pin munki-facts to munkipython and remove all pre 3.6 deprecated code

[erikng]

I've reworked all of the munki-facts code to stop supporting deprecated modules

DeprecationWarning: The readPlist function is deprecated, use load() instead

DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

DeprecationWarning: The writePlist function is deprecated, use dump() instead

This will mean that munki-facts will only support python 3.6 and higher, but this will also use munki 4.0's built in python, which uses python 3.7. I think given the upcoming changes to macOS, it would be prudent to make this breaking change now and give people a migration path.

[erikng]

Ping on this @gregneagle

[gregneagle]

So we need to communicate widely that this change will break any munki-facts you happen to deploy that are not Python-3 compatible.

[gregneagle]

Are all the included facts Python 3-ready?

[erikng]

Good call. I just tested them and 3 had issues. They are now fixed.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>admin_users</key>
	<array>
		<string>root</string>
		<string>something</string>
	</array>
	<key>backtomymac_configured</key>
	<false/>
	<key>catalina_upgrade_supported</key>
	<false/>
	<key>crashplan_username</key>
	<string>something</string>
	<key>filevault_status</key>
	<string>FileVault is On.</string>
	<key>gatekeeper_status</key>
	<string>assessments enabled</string>
	<key>local_user_dirs</key>
	<array>
		<string>something</string>
	</array>
	<key>mojave_upgrade_supported</key>
	<false/>
	<key>physical_or_virtual</key>
	<string>physical</string>
	<key>sip_status</key>
	<string>System Integrity Protection status: enabled.</string>
</dict>
</plist>

The catalina and mojave scripts are out of date, but I don't think it's relevant to fix them for this PR.

[erikng]

@gregneagle any thoughts here?

[gregneagle]

The shebang line will need to change for Munki 5.1, so let’s make that change now and then merge this after Munki 5.1 ships.

[erikng]

Done.

[natewalck]

🏓

[gregneagle]

As I mentioned before, I'll merge this after the Munki 5.1 release.

[natewalck]

Disregard, I forgot. 🤣 I saw an internal PR and pinged this as a result.

[erikng]

Let it be known that this internal PR stated this very fact about 5.1.

[natewalck]

Let it be known I don't read your comments 🤣

[natewalck]

5.1 Munki path changed back.

[natewalck]

This needs to be #!/usr/local/munki/python now I believe.

[gregneagle]

Definitely not that!

(and we're back to /usr/local/munki/munki-python...)

[natewalck]

Make up our minds! 🤣

[natewalck]

As stated, DISREGARD THIS :D It's fine again.

[erikng]

@gregneagle what do I need to do here to get this merged?