Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using latest javascript #223

Merged
merged 6 commits into from
Jan 21, 2019
Merged

Using latest javascript #223

merged 6 commits into from
Jan 21, 2019

Conversation

flbulgarelli
Copy link
Member

@flbulgarelli flbulgarelli commented Jan 19, 2019

Fixes #222

@ghost ghost assigned flbulgarelli Jan 19, 2019
@ghost ghost added the pending-review label Jan 19, 2019
@flbulgarelli
Copy link
Member Author

🆙 In the end we are not being able to solve issue #219, since it requieres updating aeson and aeson in turn is a core dependency of the current ghcjs version.

We should move to a newers ghcjs version, but this is not possible right now, since it is quite experimental.

@flbulgarelli
Copy link
Member Author

Fixes #222

Actually, it only adds support for lets and arrow functions, and it does not support classes or for-of, but is better than nothing.

@ghost ghost assigned julian-berbel Jan 21, 2019
Copy link
Member

@julian-berbel julian-berbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julian-berbel julian-berbel merged commit 6f41244 into master Jan 21, 2019
@ghost ghost removed the pending-review label Jan 21, 2019
@julian-berbel julian-berbel deleted the feature-update-javascript branch January 21, 2019 21:38
@flbulgarelli flbulgarelli mentioned this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants