FEAT(client): Introduce new logging system based on spdlog #6707
+27,199
−203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinks:
OutputDebugString()
(for debugger on Windows)Improvements compared to our old logging system based on Qt:
<W>
) is colored based on the severity:That would allow us to quickly filter log messages and know right away which subsystem is responsible for them.
log::debug()
, notqDebug()
.Only one "feature" is not reimplemented: showing a dialog in case of a fatal error, right before exiting the program.
However, that only worked on Windows and macOS using their native API, to avoid depending on a Qt event loop:
mumble/src/mumble/os_win.cpp
Lines 83 to 86 in 5452eef
mumble/src/mumble/os_macx.mm
Lines 52 to 57 in 5452eef