Allow Nz=2,3,4,5 for MFM images #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked with odd Nx, Ny and all Nz<=10. Tested with a binary compiled on CUDA v12.6 for CC=8.6, and on CUDA v10.0 (the lowest we will support from 3.11 onwards) for CC=6.1. Both give identical and expected results. If the reason for the even kernel size requirement was CUDA-related, it seems to have been addressed before v10.0. Therefore, I will merge this change, if anyone still gets errors related to this we can always rollback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #93.
It is unclear why the culprit, the now removed
AssertMsgwhich checks ifNzis even, exists. Without it, all tests still run fine and MFM images still look as expected for the affected values of Nz.There is another similar
AssertMsgchecking ifNxandNyare even, but also for those everything seems to work as expected if the assert is deactivated. This is not yet included in the PR. Would it be safe to remove this too?