Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEX-682] Use gateway URL in MX proxy service #1557

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[MEX-682] Use gateway URL in MX proxy service #1557

merged 1 commit into from
Feb 10, 2025

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • SC queries are currently performed through the API which performs forwarding to gateway

Proposed Changes

  • use gateway URL when initializing a Proxy Network Provider

How to test

  • N/A

dragos-rebegea
dragos-rebegea reviewed Feb 6, 2025
View reviewed changes
src/helpers/api.config.service.ts
@@ -132,6 +132,14 @@ export class ApiConfigService {
return apiUrl;
}

getGatewayUrl(): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it must be snapshotless gateway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is

@mad2sm0key mad2sm0key merged commit 9e17582 into development Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-rebegea dragos-rebegea dragos-rebegea left review comments

@claudiulataretu claudiulataretu claudiulataretu approved these changes

@cfaur09 cfaur09 cfaur09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mad2sm0key @claudiulataretu @dragos-rebegea @cfaur09