Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error details on /process-status #433

Merged
merged 5 commits into from
Mar 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better naming
sstanculeanu committed Mar 13, 2024
commit 01c32cee84f64f5f9bb6a0065d4699039f9eb730
2 changes: 1 addition & 1 deletion api/groups/baseTransactionGroup.go
Original file line number Diff line number Diff line change
@@ -261,7 +261,7 @@ func (group *transactionGroup) getProcessedTransactionStatus(c *gin.Context) {
return
}

shared.RespondWith(c, http.StatusOK, gin.H{"status": status.Status, "data": status.Data}, "", data.ReturnCodeSuccess)
shared.RespondWith(c, http.StatusOK, gin.H{"status": status.Status, "reason": status.Data}, "", data.ReturnCodeSuccess)
}

func getTransactionByHashAndSenderAddress(c *gin.Context, ef TransactionFacadeHandler, txHash string, sndAddr string, withEvents bool) {
4 changes: 2 additions & 2 deletions api/groups/baseTransactionGroup_test.go
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ type txProcessedStatusResp struct {
GeneralResponse
Data struct {
Status string `json:"status"`
Data string `json:"data"`
Reason string `json:"reason"`
} `json:"data"`
}

@@ -825,6 +825,6 @@ func TestTransactionGroup_getProcessedTransactionStatus(t *testing.T) {
assert.Equal(t, http.StatusOK, resp.Code)
assert.Empty(t, response.Error)
assert.Equal(t, status.Status, response.Data.Status)
assert.Equal(t, status.Data, response.Data.Data)
assert.Equal(t, status.Data, response.Data.Reason)
})
}