Mx 14120 esdt supply updates #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
requested changes
May 2, 2023
process/esdtSupplyProcessor.go
Outdated
| @@ -95,6 +103,9 @@ func addToSupply(dstSupply, sourceSupply *data.ESDTSupply) { | |||
| dstSupply.Supply = sumStr(dstSupply.Supply, sourceSupply.Supply) | |||
| dstSupply.Burned = sumStr(dstSupply.Burned, sourceSupply.Burned) | |||
| dstSupply.Minted = sumStr(dstSupply.Minted, sourceSupply.Minted) | |||
| if sourceSupply.RecomputedSupply { | |||
There was a problem hiding this comment.
because of this, we will have a wrong value if one observer returns another value for this field as the others. In this case, I strongly suggest returning an error.
iulianpascalau
previously approved these changes
May 4, 2023
sstanculeanu
previously approved these changes
May 5, 2023
| @@ -12,10 +12,10 @@ jobs: | |||
| name: Build | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Set up Go 1.x | |||
| - name: Set up Go 1.17.6 | |||
| uses: actions/setup-go@v2 | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-go@v2 | |
| uses: actions/setup-go@v3 |
on all occurences
bogdan-rosianu
dismissed stale reviews from sstanculeanu and iulianpascalau
via
de1e768
sstanculeanu
approved these changes
May 5, 2023
iulianpascalau
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update esdt supplies endpoint - treat the case when the supply of a token is recomputed