Added group for about info endpoint #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ssd04
commented
Oct 13, 2022
ssd04
commented
- add endpoint for proxy version
- manage app version and commit from build ldflags
- create separate about info processor for future metrics in about section
Makefile
Outdated
| cd ${cmd_dir} && \ | ||
| go build -v \ | ||
| -o ${binary} | ||
| -ldflags="-X main.appVersion=$(shell git describe --tags --long --dirty) -X main.commitID=$(shell git rev-parse HEAD)" |
process/aboutInfoProcessor.go
Outdated
| func (ap *aboutProcessor) GetAboutInfo() *data.GenericAPIResponse { | ||
| commit := ap.commitID | ||
| if ap.commitID != common.UndefinedCommitString { | ||
| commit = commit[:7] |
There was a problem hiding this comment.
magic number. Define a const?
bogdan-rosianu
requested changes
Oct 14, 2022
iulianpascalau
approved these changes
Oct 14, 2022
bogdan-rosianu
approved these changes
Oct 14, 2022
tanghel
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.