add guarded transactions support #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragos-rebegea
previously approved these changes
Aug 20, 2022
AdoAdoAdo
dismissed
dragos-rebegea’s stale review
The base branch was changed.
schimih
previously approved these changes
Aug 25, 2022
iulianpascalau
previously approved these changes
Aug 25, 2022
# Conflicts: # data/transaction.go # go.mod # go.sum
iulianpascalau
approved these changes
Aug 31, 2022
| @@ -743,7 +743,7 @@ func (tp *TransactionProcessor) ComputeTransactionHash(tx *data.Transaction) (st | |||
| } | |||
|
|
|||
| if len(tx.GuardianAddr) > 0 { | |||
| regularTx.GuardianAddr, err = tp.pubKeyConverter.Decode(tx.Receiver) | |||
| regularTx.GuardianAddr, err = tp.pubKeyConverter.Decode(tx.GuardianAddr) | |||
schimih
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds guarded tx support in elrond proxy